Re: [PATCH] UBI: silence erroneous GCC warning about uninitialized read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 15, 2019 at 04:55:22PM +0200, Ahmad Fatoum wrote:
> GCC reports following use of an uninitialized variable:
> 
>   ./drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data':
>   ./drivers/mtd/ubi/eba.c:904:9: warning:
>     'opnum' may be used uninitialized in this function [-Wmaybe-uninitialized]
>        err = ubi_wl_put_peb(ubi, vol_id, lnum, opnum, 0);
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> This is incorrect, because it's only called when err == 0 and opnum
> is always initialized if err == 0. Silence the warning by initializing
> a variable.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
>  drivers/mtd/ubi/eba.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux