On Wed, Jul 17, 2019 at 11:58:59AM +0200, Bastian Krause wrote:
>
> >> + struct digest *digest = NULL;
> >> + unsigned char machine_id[SHA1_DIGEST_SIZE];
> >> + char *hex_id;
> >> + int ret = 0;
> >> +
> >> + if (!__machine_id_hashable) {
> >> + pr_warn("No hashable set, will not pass id to kernel\n");
> >
> > I don't think this is worth a warning. With this series this will be
> > issued for example on all non i.MX6 boards enabled in imx_v7_defconfig.
>
> If I enable CONFIG_MACHINE_ID I'd expect the machine id being passed to
> the kernel. This is not the case for these boards. Isn't that somewhat
> surprising?
With that argument we would get a lot of warnings in a imx_v7_defconfig.
A lot of features end up unused on different boards.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
