On Fri, May 31, 2019 at 12:41 AM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote:
>
> The comment speaks of a one second polling timeout, while the polling
> is indefinite with timeout not accounted for. Thus change the comment
> to reflect the actual behavior.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
Ugh, my bad, not sure where I got that comment from, I am guessing
some version of old U-Boot code that actually implemented that timeout
properly. Definitely should be fixed.
Acked-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
Thanks,
Andrey Smirnov
> ---
> arch/arm/mach-imx/imx8-ddrc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx8-ddrc.c b/arch/arm/mach-imx/imx8-ddrc.c
> index 18454a91533b..736865eb6f12 100644
> --- a/arch/arm/mach-imx/imx8-ddrc.c
> +++ b/arch/arm/mach-imx/imx8-ddrc.c
> @@ -29,7 +29,7 @@ static u32 ddrc_phy_get_message(void __iomem *phy, int type)
>
> /*
> * When BIT0 set to 0, the PMU has a message for the user
> - * 10ms seems not enough for poll message, so use 1s here.
> + * Wait for it indefinitely.
> */
> readl_poll_timeout(phy + DDRC_PHY_REG(0xd0004),
> r, !(r & BIT(0)), 0);
> @@ -104,4 +104,4 @@ void ddrc_phy_wait_training_complete(void __iomem *phy)
> putc_ll('\r');
> putc_ll('\n');
> }
> -}
> \ No newline at end of file
> +}
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
