Re: [PATCH] scripts: kwboot: fix comparison with out-of-range constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 27, 2019 at 09:25:57AM +0200, Ahmad Fatoum wrote:
> clang detects that system char signedness will affect program runtime:
> scripts/kwboot.c:395:10: warning: result of comparison of constant 255
> with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
>                 if (*p != 0xff)
>                     ~~ ^  ~~~~
> 
> Fix this by using uint8_t where appropriate.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
>  scripts/kwboot.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux