On Tue, Apr 09, 2019 at 05:56:53PM +0800, 张忠山 wrote:
> Maybe this is a bug, I'm not sure
>
> -----------------------------------8<-----------------------------
> From 55509f359abbb1f5c24e9f0c2b9cff167f62ae4d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=BC=A0=E5=BF=A0=E5=B1=B1?= <zzs213@xxxxxxx>
> Date: Mon, 8 Apr 2019 14:34:00 +0800
> Subject: [PATCH] bugfix: check ddr mod_ranks
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Signed-off-by: 张忠山 <zzs213@xxxxxxx>
> ---
> common/ddr_spd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/ddr_spd.c b/common/ddr_spd.c
> index ec343ef5a..277d418e9 100644
> --- a/common/ddr_spd.c
> +++ b/common/ddr_spd.c
> @@ -253,7 +253,7 @@ void ddr_spd_print(uint8_t *record)
> printf("Error module type\n");
>
> printf("%-48s ", "DRAM Package ");
> - if ((s->mod_ranks & 0x10) == 1)
> + if ((s->mod_ranks & 0x10) != 0)
For sure this is buggy. Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
