On Tue, Apr 02, 2019 at 09:18:37PM +0200, Sam Ravnborg wrote:
> Hi Ahmad.
>
> > >
> > > If we introduced the following small helpers we could simplify the call sites
> > > to just use at91_get_ddram_size(AT91SAM9G45_BASE_DDRSDRC0) and similar.
> > >
> > > static inline u32 at91_get_ddram_size(void __force __iomem * addr)
> > > {
> > > return __at91_get_ddram_size(IOMEM(addr), true);
> > > }
> > >
> > > static inline u32 at91sam9g45_get_ddram_size(void __force __iomem * addr)
> > > {
> > > return __at91_get_ddram_size(IOMEM(addr), false);
> > > }
> >
> > That would still require the pointer cast to pacify the -Wint-conversion.
> > And (void*)ADDR looks only marginally better IOMEM(ADDR) IMO
> > at the cost of having sparse miss passing memory pointers
> > (__force __iomem would be equivalent to just __attribute__((noderef)), wouldn't it?)
> >
> > My preference would've been that AT91SAM9G45_BASE_DDRSDRC0 already expands
> > to a void __iomem *.
> The main idea was to get rid of the bool argument and use more explicit function
> names.
+1 for explicit function names. It's easier for the caller to get it
right.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
