Hi Ahmad. Thanks for looking into this. On Mon, Apr 01, 2019 at 12:32:57PM +0200, Ahmad Fatoum wrote: > sama5d2 was added along with the update to the upstream > device tree bindings, but wasn't wired in anywhere. > > To prepare for usage in future sama5d2 support, fix > compilation errors related to absence of locks and > unavailability of audio/i2s clock/pll handling. > > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> Another approach could have been to stub out the non-existing functions to make diff between the kernel and the barebox variant smaller. Did you consider that approach? The whole section in CONFIG_HAVE_AT91_AUDIO_PLL in dt-compat.c is also something we could drop btw. if we go the "drop all audio" stuff from clk. Also prototypes in pmc.h The patch itself looked fine. But I think that from a maintenance point of view should stub us out of it. Let me know what you think. Sam _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
