Everyone: While creating fix found in "usb: storage: Don't use "unsigned long" for 32-bit values" I spent some time reading code of our USB storage implementation. The other 25 patches is the result of that effort and my attempt to improve/simplify that codebase. Hopefuly each patch is self-explanatory. Feedback is welcome! Thanks, Andrey Smirnov Andrey Smirnov (26): usb: storage: Simplify memory allocation in usb_stor_probe() usb: storage: Replace custom debug tracing with dev_dbg usb: storage: Don't use "unsigned long" for 32-bit values usb: storage: Make usb_stor_read_capacity() a standalone function usb: storage: Make usb_stor_inquiry() a standalone function usb: storage: Make usb_stor_test_unit_ready() a standalone function usb: storage: Make usb_stor_read_10() a standalone function usb: storage: Make usb_stor_write_10() a standalone function usb: storage: Drop extra call to transport in usb_stor_write_10() usb: storage: Share code for READ(10) and WRITE(10) usb: storage: Make usb_stor_request_sense() a standalone function usb: storage: Remove unused variables usb: storage: Drop struct SCSI_cmd_block usb: hub: Do not include <scsi.h> ata: ahci: Do not include <scsi.h> usb: storage: Drop unused fields in struct us_data usb: storage: Drop unused us_blkdev_list usb: storage: Introduce usb_stor_transport() usb: storage: Use put_unaligned_be* helpers usb: Drop usb_disable_asynch() usb: storage: Drop unnecessary check in usb_stor_blk_io() usb: storage: Drop needless macro usb: storage: Use simple boolean to speficy read vs. write operation usb: storage: Simplify I/O loop in usb_stor_blk_io() usb: storage: Drop unnecessary assignment usb: storage: Inline usb_limit_blk_cnt() drivers/ata/ahci.c | 1 - drivers/usb/core/hub.c | 1 - drivers/usb/core/usb.c | 24 +- drivers/usb/storage/transport.c | 87 +++--- drivers/usb/storage/transport.h | 2 +- drivers/usb/storage/usb.c | 484 ++++++++++++++------------------ drivers/usb/storage/usb.h | 19 +- include/scsi.h | 22 -- include/usb/usb.h | 1 - 9 files changed, 265 insertions(+), 376 deletions(-) -- 2.20.1 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
