On Mon, Mar 04, 2019 at 12:38:21PM +0100, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
> common/ddr_spd.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++
> include/ddr_spd.h | 6 ++++
> 2 files changed, 87 insertions(+)
>
> diff --git a/common/ddr_spd.c b/common/ddr_spd.c
> index 9394c57fa3..a878790550 100644
> --- a/common/ddr_spd.c
> +++ b/common/ddr_spd.c
> @@ -429,3 +429,84 @@ void ddr_spd_print(uint8_t *record)
> printf("%02X", record[i]);
> printf("\n");
> }
> +
> +#define SPD_SPA0_ADDRESS 0x36
> +#define SPD_SPA1_ADDRESS 0x37
> +
> +static int select_page(void *ctx,
> + int (*xfer)(void *ctx, struct i2c_msg *msgs, int num),
> + uint8_t addr)
Indent looks strange.
> +
> +static int read_buf(void *ctx,
> + int (*xfer)(void *ctx, struct i2c_msg *msgs, int num),
> + uint8_t addr, int page, void *buf)
Same here.
> +/**
> + * spd_read_eeprom - Read contents of a SPD EEPROM
> + * @ctx: Context pointer for the xfer function
> + * @xfer: I2C message transfer function
> + * @addr: I2C bus address for the EEPROM
> + * @buf: buffer to read the SPD data to
> + *
> + * This function takes a I2C message transfer function and reads the contents
> + * from a SPD EEPROM to the buffer provided at @buf. Returns 0 for success or a
> + * negative error code otherwise.
> + */
> +int spd_read_eeprom(void *ctx,
> + int (*xfer)(void *ctx, struct i2c_msg *msgs, int num),
> + uint8_t addr, void *buf)
> +{
This looks okay.
I may have missed some trivial logic problems while my focus was at the
very important indentation - sorry :-)
Sam
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
