Re: [PATCH 1/2] ARM: zii-vf610-dev: fix boot from SD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vivien,

On Mon, Jan 21, 2019 at 12:53:04PM -0500, Vivien Didelot wrote:
> VF610 Dev Rev B and VF610 Dev Rev C boot from SD card attached to
> SDHCI1, and CFU1, SPU3 and SCU4 boot from eMMC attached to SDHCI2.
> 
> Since 5f99a8d40305 ("dts: VFxxx: Add aliases for ESDHC controllers"),
> these devices were renamed from mci0 and mci1 to mmc1 and mmc2.
> 
> To fix this, completely drop the automount-sd script, probe mmcX from
> the boot/sd script directly and use the mountpoint /mnt/mmcX.0 from
> there. At the same time, make the sd variable non global.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxx>
> ---
> --- a/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -#!/bin/sh
> -
> -if [ x${global.hostname} = xdev-rev-b -o x${global.hostname} = xdev-rev-c ];
> -then
> -    global sd=0
> -else
> -    global sd=1
> -fi
> -
> -mkdir -p /mnt/sd
> -automount /mnt/sd 'mci${global.sd}.probe=1 && mount /dev/disk${global.sd}.0 /mnt/sd'

Any special reason you evaluate $global.sd at the time the automount is
executed? I would expect a local variable here and the command put in
"" rather than ''

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux