On Thu, Jan 17, 2019 at 01:54:46PM -0800, Andrey Smirnov wrote: > On Thu, Jan 17, 2019 at 1:23 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > > Hi Andrey. > > > > On Wed, Jan 16, 2019 at 10:38:36PM -0800, Andrey Smirnov wrote: > > > Both ARM and ARM64 implement almost identical algorithms in > > > dma_alloc_coherent(). Move the code to mmu-common.c, so it can be > > > shared. > > > > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > > --- > > > arch/arm/cpu/mmu-common.c | 21 +++++++++++++++++++++ > > > arch/arm/cpu/mmu-common.h | 7 +++++++ > > We already have rch/arm/cpu/mmu.h, wait is the benefit of the extra header file? > > Arch/arm/cpu/mmu.h is a 32-bit specific file that is not used on > AArch64, which has its own counterpart in arch/arm/cpu/mmu_64.h. > Mmu-common.h contains the bits that are shared between the two > architectures. I have only looked at 32bit so far, so missed that mmu.h was only 32bit. With this in mind mmu-common.h makes good sense. Sam _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
