Hi Andrey.
On Wed, Jan 16, 2019 at 10:38:37PM -0800, Andrey Smirnov wrote:
> Both ARM and ARM64 have identical code for
> dma_sync_single_for_cpu(). Move it to mmu-common.c so it can be shared.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
> arch/arm/cpu/mmu-common.c | 8 ++++++++
> arch/arm/cpu/mmu.c | 7 -------
> arch/arm/cpu/mmu_64.c | 7 -------
> 3 files changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/cpu/mmu-common.c b/arch/arm/cpu/mmu-common.c
> index 8c7d61447..a7d3b5b11 100644
> --- a/arch/arm/cpu/mmu-common.c
> +++ b/arch/arm/cpu/mmu-common.c
> @@ -8,6 +8,14 @@
>
> #include "mmu.h"
>
> +
> +void dma_sync_single_for_cpu(dma_addr_t address, size_t size,
> + enum dma_data_direction dir)
> +{
> + if (dir != DMA_TO_DEVICE)
> + dma_inv_range((void *)address, size);
> +}
I cannot see how this will work?!?
We are on a v8 architecture for a 64bit variant.
But in cache.c we have only:
DEFINE_CPU_FNS(v4)
DEFINE_CPU_FNS(v5)
DEFINE_CPU_FNS(v6)
DEFINE_CPU_FNS(v7)
So I do not see how we call v8_inv_dcache_range() here.
Do I miss something?
Sam
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
