Re: [PATCH] mtd: core: Fix erase area alignment for non power of 2 erasesize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 12, 2019 at 01:58:28PM +0100, Ladislav Michl wrote:
> On Thu, Jan 10, 2019 at 09:32:07AM +0100, Sascha Hauer wrote:
> > On Wed, Jan 09, 2019 at 12:28:14PM +0100, Ladislav Michl wrote:
> > > Devices as AT45DB161 DataFlash uses non power of two page size (528)
> > > while present alignment algorithm relies on erasesize being power
> > > of 2.
> > > Fix that by introducing helper functions rounding to any multiply.
> > > Note that logic is sligthly changed to be consistent as ending
> > > address is moved forward to include also last byte meant to be
> > > erased while previous implementation moved it backward.
> > > 
> > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
> > > ---
> > >  drivers/mtd/core.c     | 28 ++++++++++++++++++++++------
> > >  include/linux/kernel.h |  5 +++++
> > >  2 files changed, 27 insertions(+), 6 deletions(-)
> > 
> > Applied, thanks
> 
> Hi Sascha,
> 
> I was searching for paper bag, but was unable to find anything thick
> enouh to cover behind :-/ This version is buggy and I noticed right
> now when testing on another board. Corrected version follows, which
> is also 192 bytes shorter for my ARM target. It seems next branch
> at https://git.pengutronix.de/ is not yet updated, so perhaps my fault
> won't affect anyone.

I did in the meantime, but updated it now again with your updated patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux