On Fri, Jan 11, 2019 at 2:47 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > On Thu, Jan 10, 2019 at 11:16:07AM -0800, Andrey Smirnov wrote: > > On Thu, Jan 10, 2019 at 2:09 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > > > > > Hi Andrey, > > > > > > with the price of having to dispatch the differences in a switch/case > > > later. This often works but here I don't think this is an improvement. > > > > > > > I am confused, is this a comment for this specific patch or more than > > that, since you mention a switch statement? Can you drop: > > The comment was specific to these patches: > > > > PCI: Convert postscan_setup_bridge() to use a loop > > PCI: Convert prescan_setup_bridge() to use a loop > > PCI: Consolidate limit/base settting code > > and this one: > > PCI: Replace last_* variables with an array > > > > > and apply the rest? > > I tried, it didn't apply. Yeah, dropping "PCI: Replace last_* variables with an array" will require some rework. >Could you respin the remaining patches? Sure, will do in v2. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
