Hi Anthony. On Wed, Jan 09, 2019 at 11:27:54PM +0300, Antony Pavlov wrote: > The patch fixes the following compiler's warning: > > In file included from include/common.h:33:0, > from arch/arm/mach-zynq/zynq.c:18: > arch/arm/include/asm/io.h:4:0: warning: "IO_SPACE_LIMIT" redefined > #define IO_SPACE_LIMIT 0 > > In file included from > arch/arm/mach-zynq/zynq.c:17:0: > include/asm-generic/io.h:92:0: note: this is the location of the previous definition > #define IO_SPACE_LIMIT 0xffff > > Cc: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx> > --- > arch/arm/mach-zynq/zynq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-zynq/zynq.c b/arch/arm/mach-zynq/zynq.c > index a0a8d0d249..dd8f12c16a 100644 > --- a/arch/arm/mach-zynq/zynq.c > +++ b/arch/arm/mach-zynq/zynq.c > @@ -14,7 +14,6 @@ > */ > > #include <asm/system.h> > -#include <asm-generic/io.h> > #include <common.h> > #include <init.h> > #include <restart.h> This patch rely on other headers to pull in <asm/io.h>. As zynq.c uses a lot of functions from <asm/io.h> then using an explicit include would be better. Just my opinion, you could argue this is bikeshedding. Sam _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
