Re: [PATCH v2 1/2] recursive_action: add ACTION_SORT flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



NAK! NAK!

There are two terrible mistakes - indeed the patches produce a very reproducible
environment. Independent of what environment you want, you'd get an empty one.

Problem 1: a2f3b3d
it requires ACTION_RECURSE | ACTION_SORT

Problem 2: f5c0978
+			e->dirname = xstrdup(next->d_name);
should be much more like:
+			e->dirname = xstrdup(fileName);

Sorry for that, problem 2 should really *not* have happened.


- Florian

Am Montag, den 07.01.2019, 08:58 +0100 schrieb s.hauer@xxxxxxxxxxxxxx:
> On Thu, Jan 03, 2019 at 11:53:27AM +0000, Baeuerle, Florian wrote:
> > Hi Sascha,
> > 
> > thanks a lot!
> > 
> > There's two things I noticed when reviewing the patches:
> > 
> > The commit message of 47866ba5 is a bit misleading since poison.h is no
> > longer
> > being added in the commit.
> > 
> > 861ce6d looks a bit weird, I guess that's a typo (ACTION_SORT |
> > ACTION_SORT). 
> 
> Ups, indeed. I fixed that.
> 
> Thanks,
> Sascha
> 
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux