Re: [PATCH v1 3/5] arm: fix no prototype for barebox_arm_reset_vector()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 31, 2018 at 09:07:23AM +0100, Sam Ravnborg wrote:
> Fix the following warning:
> 
> PBLCC   arch/arm/boards/at91sam9261ek/pbl-lowlevel_init.o
> arch/arm/boards/at91sam9261ek/lowlevel_init.c:120:26:
> warning: no previous prototype for ‘barebox_arm_reset_vector’ [-Wmissing-prototypes]
> 
> Prototype added so it covers machs with their own
> definition and the machs using the arm general variant
> 
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> ---
>  arch/arm/include/asm/barebox-arm.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/include/asm/barebox-arm.h b/arch/arm/include/asm/barebox-arm.h
> index e065b479e..312685486 100644
> --- a/arch/arm/include/asm/barebox-arm.h
> +++ b/arch/arm/include/asm/barebox-arm.h
> @@ -25,6 +25,7 @@
>  #ifndef _BAREBOX_ARM_H_
>  #define _BAREBOX_ARM_H_
>  
> +#include <init.h>
>  #include <linux/sizes.h>
>  #include <asm-generic/memory_layout.h>
>  #include <linux/kernel.h>
> @@ -58,6 +59,7 @@ void setup_c(void);
>  void relocate_to_current_adr(void);
>  void relocate_to_adr(unsigned long target);
>  void __noreturn barebox_arm_entry(unsigned long membase, unsigned long memsize, void *boarddata);
> +void __naked __bare_init barebox_arm_reset_vector(void);

I had to drop this one as it breaks compilation on some boards. Some
boards need r0 from the ROM so they have:

void __naked __bare_init barebox_arm_reset_vector(uint32_t *data)

We have to harmonize these first. I suggest to use

void __naked __bare_init barebox_arm_reset_vector(uint32_t r0, uint32_t r1, uint32_t r2)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux