Peter Korsgaard <peter@xxxxxxxxxxxxx> writes: >>>>>> "Rouven" == Rouven Czerwinski <r.czerwinski@xxxxxxxxxxxxxx> writes: > > Hi, > > >> >> v5: > >> >> - Add defines for register and base values > >> >> from Sascha Hauer and Roland Hieber > >> > >> > Applied, thanks > >> > >> Where did those defines actually go? I still see a bunch of magic > >> values. > >> > > They are either contained directly in the original patch (for 5/9) or > > in the new 9/9 patch. > > Sorry, I don't follow. I still see magic values in E.G.: > > 97818de1a3d serial_ns16550: add raspberry pi compatible and init > 776de843636 ARM: rpi: retrieve miniuart clock from firmware > > Wasn't this comment about replacing them with sensible defines? Yes, looking into the next branch, it still contains the old patchset without the defines. Maybe Sascha has not pushed yet? - Rouven _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox