Re: [PATCH] imd: model and compatible missing in metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 17, 2018 at 02:18:52PM +0300, Antony Pavlov wrote:
> On Thu, 13 Dec 2018 07:33:56 +0100
> "Thorsten K. Scherer" <t.scherer@xxxxxxxxxxxx> wrote:
> 
> Hi!
> 
> 
> > fixes 97e81f2
> > 
> > Signed-off-by: Thorsten K. Scherer <t.scherer@xxxxxxxxxxxx>
> > ---
> >  include/asm-generic/barebox.lds.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/asm-generic/barebox.lds.h b/include/asm-generic/barebox.lds.h
> > index 74d3ca4a9..decaab79a 100644
> > --- a/include/asm-generic/barebox.lds.h
> > +++ b/include/asm-generic/barebox.lds.h
> > @@ -66,7 +66,7 @@
> >  #define BAREBOX_IMD				\
> >  	KEEP(*(.barebox_imd_start))		\
> >  	KEEP(*(.barebox_imd_1*))		\
> > -	*(.barebox_imd_0*)			\
> > +	KEEP(*(.barebox_imd_0*))		\
> >  	KEEP(*(.barebox_imd_end))
> >  
> >  #if defined(CONFIG_ARCH_BAREBOX_MAX_BARE_INIT_SIZE) && \
> > -- 
> > 2.19.1
> 
> It looks like this patch has unobvious drawback.
> The bareboximd utility sees too many 'model' and 'compatible' strings in a single image, e.g.:

Now I remember what the intention was that this line looks so apparently
different from the other ones ;)

To get the compatible strings into the binary I have created imd_used().
This should be called with the symbol that should be kept in the
resulting image.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux