On Wed, Dec 12, 2018 at 03:10:51PM +0100, Rouven Czerwinski wrote:
> Add the compatible for the Raspberry Pi AUX UART and an init function which
> enables it via the aux register and configures the correct shift value.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@xxxxxxxxxxxxxx>
> ---
> drivers/serial/serial_ns16550.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 8ddcfdbef..e872fb886 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -253,6 +253,15 @@ static void ns16550_jz_init_port(struct console_device *cdev)
> ns16550_serial_init_port(cdev);
> }
>
> +static void rpi_init_port(struct console_device *cdev)
> +{
> + struct ns16550_priv *priv = to_ns16550_priv(cdev);
> +
> + writeb(0x01, 0x3f215004);
> + priv->plat.shift = 2;
> + ns16550_serial_init_port(cdev);
> +}
Please indent with tabs.
> +
> /*********** Exposed Functions **********************************/
>
> /**
> @@ -353,6 +362,11 @@ static __maybe_unused struct ns16550_drvdata tegra_drvdata = {
> .linux_console_name = "ttyS",
> };
>
> +static struct ns16550_drvdata rpi_drvdata = {
> + .init_port = rpi_init_port,
> + .linux_console_name = "ttyS",
> +};
Here aswell.
Please add a __maybe_unused like done with the other drvdata in the
driver. Otherwise we'll generate a unused warning when RPI support is
disabled.
Sascha
> +
> static int ns16550_init_iomem(struct device_d *dev, struct ns16550_priv *priv)
> {
> struct resource *iores;
> @@ -528,6 +542,12 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
> .data = &jz_drvdata,
> },
> #endif
> +#if IS_ENABLED(CONFIG_MACH_RPI_COMMON)
> + {
> + .compatible = "brcm,bcm2835-aux-uart",
> + .data = &rpi_drvdata,
> + },
> +#endif
> {
> /* sentinel */
> },
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
