On Thu, Dec 06, 2018 at 11:30:57PM -0800, Andrey Smirnov wrote:
> The code doesn't seem to be time-sensitive enough to warrant calling
> get_time_ns() twice instead of caching its value and using it no both
> places.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
> drivers/led/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/led/core.c b/drivers/led/core.c
> index a388e6b36..f11504ace 100644
> --- a/drivers/led/core.c
> +++ b/drivers/led/core.c
> @@ -127,12 +127,13 @@ static void led_blink_func(struct poller_struct *poller)
> struct led *led;
>
> list_for_each_entry(led, &leds, list) {
> + const uint64_t now = get_time_ns();
> int on;
>
> if (!led->blink && !led->flash)
> continue;
>
> - if (led->blink_next_event > get_time_ns()) {
> + if (led->blink_next_event > now) {
> continue;
> }
>
> @@ -140,7 +141,7 @@ static void led_blink_func(struct poller_struct *poller)
> if (on)
> on = led->max_value;
>
> - led->blink_next_event = get_time_ns() +
> + led->blink_next_event = now +
> (led->blink_states[led->blink_next_state] * MSECOND);
> led->blink_next_state = (led->blink_next_state + 1) %
> led->blink_nr_states;
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
