Re: [PATCH] net: macb: dma_sync_* receive buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ladis,

On Fri, Nov 16, 2018 at 04:07:25PM +0100, Lucas Stach wrote:
> > @@ -237,12 +241,17 @@ static int macb_recv(struct eth_device *edev)
> > >  				taillen = length - headlen;
> > >  				memcpy((void *)NetRxPackets[0],
> > >  				       buffer, headlen);
> > > +				dma_sync_single_for_cpu((unsigned long)macb->rx_buffer,
> > > +							taillen, DMA_FROM_DEVICE);
> > >  				memcpy((void *)NetRxPackets[0] + headlen,
> >  				       macb->rx_buffer, taillen);
> 
> This is missing a dma_sync_single_for_device() here, matching the
> ...for_cpu added above. Otherwise patch looks good.

Any input to this one or an updated patch?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux