Re: [PATCH] fixup! drivers: caam: add RNG software self-test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 03, 2018 at 11:15:32AM +0100, Roland Hieber wrote:
> Fix compile error and warning:
> 
>     drivers/crypto/caam/rng_self_test.c: In function 'caam_rng_self_test':
>     drivers/crypto/caam/rng_self_test.c:167:2: error: expected ';' before '}' token
>       }
>       ^
>     drivers/crypto/caam/rng_self_test.c:134:11: warning: unused variable 'i' [-Wunused-variable]
>       int ret, i, desc_size = 0, result_size = 0, job_err = 0;
>                ^
> 
> Signed-off-by: Roland Hieber <r.hieber@xxxxxxxxxxxxxx>
> ---
> Hi Sascha,
> 
> On Mon, Dec 03, 2018 at 09:01:56AM +0100, Sascha Hauer wrote:
> > Hi Roland,
> > 
> > Applied with several adjustments, see below.
> 
> Right, thank you for those! I found two small problems left.

Applied, thanks

Sascha

> 
>  - Roland
> ---
>  drivers/crypto/caam/rng_self_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/caam/rng_self_test.c b/drivers/crypto/caam/rng_self_test.c
> index 149b334f23..aab4fa2e47 100644
> --- a/drivers/crypto/caam/rng_self_test.c
> +++ b/drivers/crypto/caam/rng_self_test.c
> @@ -131,7 +131,7 @@ static void rng_self_test_done(struct device_d *dev, u32 *desc, u32 err, void *a
>   */
>  int caam_rng_self_test(struct device_d *dev, const u8 caam_era, const u8 rngvid, const u8 rngrev)
>  {
> -	int ret, i, desc_size = 0, result_size = 0, job_err = 0;
> +	int ret, desc_size = 0, result_size = 0, job_err = 0;
>  	const u32 *rng_st_dsc;
>  	const u8 *exp_result;
>  	u32 *desc;
> @@ -163,7 +163,7 @@ int caam_rng_self_test(struct device_d *dev, const u8 caam_era, const u8 rngvid,
>  
>  	if (!result || !desc) {
>  		ret = -ENOMEM;
> -		goto err
> +		goto err;
>  	}
>  
>  	construct_rng_self_test_jobdesc(desc, rng_st_dsc, result, desc_size);
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux