On Thu, Nov 29, 2018 at 12:39:31PM +0100, Steffen Trumtrar wrote: > Do not drop the error value and use it as a return value instead. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > --- > drivers/net/designware.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/designware.c b/drivers/net/designware.c > index 104258e21c51..cb7c4a13719c 100644 > --- a/drivers/net/designware.c > +++ b/drivers/net/designware.c > @@ -99,8 +99,7 @@ static int dwc_ether_mii_write(struct mii_bus *dev, int addr, int reg, u16 val) > writel(miiaddr | MII_CLKRANGE_150_250M | MII_BUSY, &mac_p->miiaddr); > > /* Needed as a fix for ST-Phy */ > - dwc_ether_mii_read(dev, addr, reg); > - return 0; > + return dwc_ether_mii_read(dev, addr, reg); dwc_ether_mii_read() normally returns the register value on success, returning this from dwc_ether_mii_write() looks wrong. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
