Re: [PATCH 2/3] ARM: i.MX: Add max_load_size option to boards that will need it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 20, 2018 at 8:04 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
>
> The max_load_size option makes sure that only the portion of the image
> is loaded to SRAM that fits into it.
>
> Note this does not cover the whole available SRAM area for all boards,
> for the bigger SRAM areas only a part is chosen that is enough to fit
> the initial loader in.
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
>  arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.imxcfg            | 1 +
>  arch/arm/boards/nxp-imx8mq-evk/flash-header-imx8mq-evk.imxcfg    | 1 +
>  .../flash-header-technexion-wandboard.imxcfg                     | 1 +
>  arch/arm/boards/zii-imx6q-rdu2/flash-header-rdu2.imxcfg          | 1 +
>  4 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.imxcfg b/arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.imxcfg
> index 400a870154..9e8dce5877 100644
> --- a/arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.imxcfg
> +++ b/arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.imxcfg
> @@ -1,3 +1,4 @@
>  soc imx6
>  loadaddr 0x00907000
> +max_load_size 0x11000
>  dcdofs 0x400
> diff --git a/arch/arm/boards/nxp-imx8mq-evk/flash-header-imx8mq-evk.imxcfg b/arch/arm/boards/nxp-imx8mq-evk/flash-header-imx8mq-evk.imxcfg
> index a12c28fceb..14e4a595a0 100644
> --- a/arch/arm/boards/nxp-imx8mq-evk/flash-header-imx8mq-evk.imxcfg
> +++ b/arch/arm/boards/nxp-imx8mq-evk/flash-header-imx8mq-evk.imxcfg
> @@ -1,4 +1,5 @@
>  soc imx8mq
>
>  loadaddr 0x007E1000
> +max_load_size 0x10000
>  dcdofs 0x400
> diff --git a/arch/arm/boards/technexion-wandboard/flash-header-technexion-wandboard.imxcfg b/arch/arm/boards/technexion-wandboard/flash-header-technexion-wandboard.imxcfg
> index 33621117d4..68cb08e200 100644
> --- a/arch/arm/boards/technexion-wandboard/flash-header-technexion-wandboard.imxcfg
> +++ b/arch/arm/boards/technexion-wandboard/flash-header-technexion-wandboard.imxcfg
> @@ -1,3 +1,4 @@
>  loadaddr 0x00907000
>  soc imx6
> +max_load_size 0x11000
>  dcdofs 0x400
> diff --git a/arch/arm/boards/zii-imx6q-rdu2/flash-header-rdu2.imxcfg b/arch/arm/boards/zii-imx6q-rdu2/flash-header-rdu2.imxcfg
> index 400a870154..9e8dce5877 100644
> --- a/arch/arm/boards/zii-imx6q-rdu2/flash-header-rdu2.imxcfg
> +++ b/arch/arm/boards/zii-imx6q-rdu2/flash-header-rdu2.imxcfg
> @@ -1,3 +1,4 @@
>  soc imx6
>  loadaddr 0x00907000
> +max_load_size 0x11000

Sascha:

The change above bricks Barebox on RDU2 because load size of 0x11000
isn't enough. Tracing what hdr->boot_data.size was set to prior to
this series ends up with 0x1d000 as a number, using which appears to
fix the problem on the real board, so we probably should max_load_size
to at least that much. I am hoping you can fix it on your end, but let
me know if you need me to generate a fixup patch.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux