Based on linux v3.2 patch: e6ac89fabd030704eac691dab7783ebe06e6b2c1
kbuild: Correctly deal with make options which contain an "s"
When using remake, which is based on gnumake, if you invoke
an example build as shown below, the build will become silent
due to the top level make file incorrectly guessing that
the end user wants a silent build because an argument that
contained an "s" was used. Here are two examples one with remake
and one with straight gnumake.
remake --no-extended-errors
make --warn-undefined-variables
Fix up the top level Makefile to use filter to parse the options
that mean silent instead of findstring catching other random
arguments containing an "s".
Signed-off-by: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
CC: Michal Marek <mmarek@xxxxxxx>
CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
CC: linux-kbuild@xxxxxxxxxxxxxxx
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index dedb16d60069..cddff1267972 100644
--- a/Makefile
+++ b/Makefile
@@ -252,7 +252,7 @@ endif
# If the user is running make -s (silent mode), suppress echoing of
# commands
-ifneq ($(findstring s,$(MAKEFLAGS)),)
+ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
quiet=silent_
endif
--
2.19.2
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
