Re: [PATCH v2 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 27, 2018 at 08:37:09AM +0100, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
>  arch/mips/include/asm/asm.h | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/arch/mips/include/asm/asm.h b/arch/mips/include/asm/asm.h
> index 12e17581b8..b9ccccc0cc 100644
> --- a/arch/mips/include/asm/asm.h
> +++ b/arch/mips/include/asm/asm.h
> @@ -79,6 +79,35 @@ symbol:		.frame	sp, framesize, rpc
>  		.globl	symbol;                         \
>  symbol:
>  
> +/*
> + * ENTRY_FUNCTION - mark start of entry function
> + */
> +#define ENTRY_FUNCTION(symbol)				\
> +	.set noreorder;					\
> +	.section .text_head_entry.BOARD_PBL_START;	\

In your boards you have:

#define BOARD_PBL_START start_8devices_lima
ENTRY_FUNCTION(BOARD_PBL_START)

It's strange that you pass in the same string both as macro argument and
preprocessor define. Seems like you should drop BOARD_PBL_START and use
"symbol" directly.

> +							\
> +	la	a0, dtb_start;				\
> +	la	a1, dtb_end;				\
> +	la	v0, pbl_main_entry;			\
> +	jal	v0;					\
> +	 nop;						\

Whitespace inconsistency here.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux