Re: [PATCH] arch: *: cpuinfo: harmonize command description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 Nov 2018 09:12:00 +0100
Ulrich Ölmann <u.oelmann@xxxxxxxxxxxxxx> wrote:

Hello Robert!

AFAIR you are a native English speaker.

Would you please comment this change

> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")

Which version of the cpuinfo command description is better?

-- 
Best regards,
  Antony Pavlov

> Unify the different cpuinfo commands' description and adjust them to the
> descriptions of "clk_dump" and "devinfo".
> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@xxxxxxxxxxxxxx>
> ---
>  arch/arm/cpu/cpuinfo.c      | 2 +-
>  arch/mips/lib/cpuinfo.c     | 2 +-
>  arch/openrisc/lib/cpuinfo.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/cpuinfo.c b/arch/arm/cpu/cpuinfo.c
> index 175475b038dc..2421b91e57f1 100644
> --- a/arch/arm/cpu/cpuinfo.c
> +++ b/arch/arm/cpu/cpuinfo.c
> @@ -268,7 +268,7 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show info about CPU")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  	BAREBOX_CMD_COMPLETE(empty_complete)
>  BAREBOX_CMD_END
> diff --git a/arch/mips/lib/cpuinfo.c b/arch/mips/lib/cpuinfo.c
> index fb02a4d20217..a327672f78a5 100644
> --- a/arch/mips/lib/cpuinfo.c
> +++ b/arch/mips/lib/cpuinfo.c
> @@ -63,6 +63,6 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  BAREBOX_CMD_END
> diff --git a/arch/openrisc/lib/cpuinfo.c b/arch/openrisc/lib/cpuinfo.c
> index 175adc582ca4..3d7fcb1f59ce 100644
> --- a/arch/openrisc/lib/cpuinfo.c
> +++ b/arch/openrisc/lib/cpuinfo.c
> @@ -198,6 +198,6 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  BAREBOX_CMD_END
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux