On Wed, Nov 14, 2018 at 07:59:25AM -0800, Andrey Smirnov wrote: > On Wed, Nov 14, 2018 at 12:52 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > > > Previous implementation used to add a number to the device names > > for devices registered from the device tree which did not have a 'reg' > > property, thus a device node named "state" resulted in a device name > > "state.<x>". Current implementation skips that number and we get a > > device named "state". This conflicts with our barebox state > > implementation which tries to register a device named "state" itself. > > We could rename the state device nodes of all our device trees, but it > > causes less trouble to rename the devices. > > > > State implementation will register a device named the same as alias > pointing to corresponding node, so the problem only arises if DT has > both a state node named "foo" and an alias to it named "foo" as well. > It seems that the whole alias/standalone device creation code in > common/state/state.c was written precisely because original DT naming > scheme was not producing "fixed/stable" names, so changing then naming > scheme from matching what Linux does in order to fit some assumptions > in state code and unfortunate DT naming, while the easiest solution, > seems a bit backwards. > > Can we fix this using an early internal DT fixup that would rename > problematic node and maybe even print a warning urging users to rename > their state nodes? We have boards that have multiple state instances registered with different names, but all follow the same pattern and have the same problem, so it's not only "state" that causes problems, but could be any string. Lucas noted there were problems with imx-thermal aswell. We have the general problem that devices that have variables attached to them shall have a specific name, so we must make sure these are not used by devices registered from the device tree. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
