Re: [PATCH] Add initial support for the EVB-KSZ9477 eval board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 05, 2018 at 08:32:59AM +0100, Sascha Hauer wrote:
> Hi Sam,
> 
> On Sat, Nov 03, 2018 at 12:31:12AM +0100, Sam Ravnborg wrote:
> > On Fri, Nov 02, 2018 at 10:07:43AM +0100, Sascha Hauer wrote:
> > > From: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> > > 
> > > The EVB-KSZ9477 is an evaluation board for the KSZ9477 ethernet switch.
> > > This board is equipped with a atsama5d3 SoC with 256MiB of SDRAM, 256MiB
> > > of NAND flash and a SD card slot.
> > > 
> > > For now only second stage booting is supported with AT91bootstrap as
> > > first stage loader.
> > Reminds me...
> > 
> > I have noticed a brown-paper-bug introduced by me that would
> > hurt first stage bootloaders.
> > But only for at91sam926x boards I think, that this is likely not
> > considered.
> 
> 
> > +#define at91_sdramc_write(field, value) \
> > +	__raw_writel((value), cfg->sdramc + (field))
> 
> I prefer using plain __raw_writel rather than creating a new wrapper.
> The reason is a series I created that gets rid of these kind of wrappers
> in AT91 which decide during compile time on which SoC we are running.
> The above is not one of these, but I think doing it without accessors
> fits better into the series I created.

Fine, and thanks a lot for taking care of this!

	Sam

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux