Instead of allocating struct macb_device and a struct eth_device separately just use the eth_device structure that is already embedded in struct macb_device but currently unused. Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> --- drivers/net/macb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 28065e1e13..fe192f9bf4 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -618,9 +618,10 @@ static int macb_probe(struct device_d *dev) const char *pclk_name; u32 ncfgr; - edev = xzalloc(sizeof(struct eth_device) + sizeof(struct macb_device)); - edev->priv = (struct macb_device *)(edev + 1); - macb = edev->priv; + macb = xzalloc(sizeof(*macb)); + edev = &macb->netdev; + edev->priv = macb; + dev->priv = macb; macb->dev = dev; -- 2.19.1 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox