common/ddr_spd.c:281:28: warning: bitwise comparison always evaluates to false

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

I have tried to build barebox with gcc-8.2.

I see this warning:

common/ddr_spd.c:281:28:
common/ddr_spd.c: In function ‘ddr_spd_print’:
common/ddr_spd.c:281:28: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
  if ((s->mod_ranks & 0x10) == 1)
                            ^~

Git blame show me this:

f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 280)    printf("%-48s ", "DRAM Package ");
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 281)    if ((s->mod_ranks & 0x10) == 1)
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 282)            printf("Stack\n");
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 283)    else
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 284)            printf("Planar\n");

Please fix it.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux