On Sat, Oct 27, 2018 at 10:42:35AM +0200, Sam Ravnborg wrote: > Hi Andrey. > > > This patch series is the result of my work on extending various gpio_* > > commands in Barebox CLI to allow referencing GPIOs by a label assigned > > to them via Device Tree or in any other way. > > Thanks, I have missed this in the past. > > I browsed the patches. > There are a few that is missing a newline, that you may fix if you post a v2. > But other than that everything looked good to me. > > > AFAICT majority of callers of simple_strto*() functions don't really > > do very strict error checking which seems really undesirable. With > > kstrto*() functions in place, and assuming there's no objections to > > that, what do you think about a separate patch series to replace all > > of the uses of simple_strto*() with kstrto*() and eventually drop > > majority of simple_strto*() implementation code? > > There should be only one implmentation, and the more strict > variant makes good sense. The kstrtox functions epect a terminating 0 or a newline at the end of the string. strtoull_suffix() is at least one place that cannot directly be implemented with the kernel functions. Otherwise yes, I am also in favour to be more strict with the string checking. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
