Hi Ladis, On Fri, Oct 26, 2018 at 12:37:19AM +0200, Ladislav Michl wrote: > Use global variable dfu_function to autostart DFU. As similar code > is used to start multifunction gadget using command, move common > code to common/usbgadget.c and consolidate it. > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > --- > This is a draft, comments welcome. Getting > Cannot set parameter otg.mode: No such device I just sent a fix for this. > but that's same as before this patch. Documentation is probably > also worth updating... Indeed. > diff --git a/commands/usbgadget.c b/commands/usbgadget.c > index a1744cbe1..416b2acfc 100644 > --- a/commands/usbgadget.c > +++ b/commands/usbgadget.c > @@ -30,14 +30,18 @@ > #include <usb/dfu.h> > #include <usb/gadget-multi.h> > > +int usbgadget_register(bool dfu_set, const char *dfu_opts, > + bool fastboot_set, const char *fastboot_opts, > + bool create_serial, bool is_acm, bool export_bbu); > + This should get a prototype somewhere in include/, but that's probably due to the draft status of this patch. Otherwise looks fine to me. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
