On Tue, Oct 23, 2018 at 03:15:31PM +0200, Marcin Niestroj wrote: > Option 54 (Server Identifier) is something different than > SIADDR (Server IP address). Currently they are used > interchangeably. This causes DHCPNAK with DHCP servers that > have configured different values for each field. > > Create new 'dhcp_serverip' field in 'struct dhcp_result', so we treat > option 54 separately. This fixes DHCP requests for servers that send > two different values for SIADDR and option 54 in DHCPOFFER. > > Fixes: 528298b702a0 ("net: dhcp: rework") > Fixes: e18cc5b7e9ce ("DHCP: fix option 54 passing") > Signed-off-by: Marcin Niestroj <m.niestroj@xxxxxxxxxxxxxxxx> > --- > include/dhcp.h | 1 + > net/dhcp.c | 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) Tested here, still works for me. Other than that I must say I do not fully overview the impact of this patch, so I just hope for the best ;) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox