On Thu, Oct 11, 2018 at 06:42:16PM +0200, Ladislav Michl wrote: > Recently added check for overlapping environment always succeeds [*] > for mtd partitions not starting at the beginning of flash as > cdev.offset is not set. Here's a proposed fix, however someone > familiar with codebase should verify/correct this oneliner. Well, that's not the right way fixing it as other fs operations (protect etc.) are using offset from beginning of the partition... > Thank you. > > [*] Environment partition (0x00000000-0x000020ff) overlaps with partition dataflash0.at91bootstrap (0x00000000-0x000041ff), not using it > where "Environment partition" actually starts at 0x4200. > --- > drivers/mtd/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c > index 58b20cbc2..b40a3303c 100644 > --- a/drivers/mtd/core.c > +++ b/drivers/mtd/core.c > @@ -640,6 +640,7 @@ int add_mtd_device(struct mtd_info *mtd, const char *devname, int device_id) > > mtd->cdev.ops = &mtd_ops; > mtd->cdev.size = mtd->size; > + mtd->cdev.offset = mtd->master_offset; > if (device_id == DEVICE_ID_SINGLE) > mtd->cdev.name = xstrdup(devname); > else > -- > 2.19.1 > _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
