On Thu, Sep 27, 2018 at 12:05 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > On Tue, Sep 25, 2018 at 06:34:15PM -0700, Andrey Smirnov wrote: > > Create a shared DDR configuration header based on configuration used > > by i.MX7D SabreSD board. > > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > --- > > .../flash-header-mx7-sabresd.imxcfg | 79 +------------------ > > .../flash-header/imx7d-ddr-default.imxcfg | 78 ++++++++++++++++++ > > 2 files changed, 79 insertions(+), 78 deletions(-) > > create mode 100644 arch/arm/mach-imx/include/mach/flash-header/imx7d-ddr-default.imxcfg > > > > diff --git a/arch/arm/mach-imx/include/mach/flash-header/imx7d-ddr-default.imxcfg b/arch/arm/mach-imx/include/mach/flash-header/imx7d-ddr-default.imxcfg > > new file mode 100644 > > index 000000000..e98f055ee > > --- /dev/null > > +++ b/arch/arm/mach-imx/include/mach/flash-header/imx7d-ddr-default.imxcfg > > @@ -0,0 +1,78 @@ > > +/* > > + * Copyright (C) 2016 NXP Semiconductors > > + * > > + * SPDX-License-Identifier: GPL-2.0 > > + * > > + * Refer docs/README.imxmage for more details about how-to configure > > + * and create imximage boot image > > + * > > + * The syntax is taken as close as possible with the kwbimage > > + * > > + * Taken from upstream U-Boot git://git.denx.de/u-boot.git, commit > > + * 1a8150d4b16fbafa6f1d207ddb85eda7dc399e2d > > + */ > > + > > +#include <mach/imx7-ddr-regs.h> > > + > > +wm 32 0x30340004 0x4F400005 > > + > > +wm 32 0x30391000 0x00000002 > > + > > +wm 32 MX7_DDRC_MSTR 0x01040001 > > How default is this default header? It looks like it only works for the > exact DDR type and size like used on the i.MX7D SabreSD board. Many boards > are more or less copied from the eval boards, so having a common DDR > setup header is a good thing, but calling this "default" sounds a bit > strong. How about replacing "default" with "sabresd"? Sounds good. Will do in v2. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
