Re: [PATCH 3/3] net: dhcp: add global variable for retries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04.09.2018 08:12, Sascha Hauer wrote:
> Hi Oleg,

Hi Sascha,

> 
> On Fri, Aug 31, 2018 at 09:01:32AM +0000, Oleg.Karfich@xxxxxxxx wrote:
>> Signed-off-by: Oleg Karfich <oleg.karfich@xxxxxxxx>
>> ---
>>  net/dhcp.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/net/dhcp.c b/net/dhcp.c
>> index 6394397..92e0501 100644
>> --- a/net/dhcp.c
>> +++ b/net/dhcp.c
>> @@ -448,6 +448,7 @@ static char *global_dhcp_bootfile;
>>  static char *global_dhcp_oftree_file;
>>  static char *global_dhcp_rootpath;
>>  static char *global_dhcp_tftp_server_name;
>> +static char *global_dhcp_retries;
>>  static char *global_dhcp_option224;
>>  
>>  static void set_res(char **var, const char *res)
>> @@ -629,6 +630,7 @@ static int dhcp_global_init(void)
>>  	globalvar_add_simple_string("dhcp.user_class", &global_dhcp_user_class);
>>  	globalvar_add_simple_string("dhcp.oftree_file", &global_dhcp_oftree_file);
>>  	globalvar_add_simple_string("dhcp.tftp_server_name", &global_dhcp_tftp_server_name);
>> +	globalvar_add_simple_string("dhcp.retries", &global_dhcp_retries);
> 
> This adds a global variable, but it is not used, so this still has no
> effect. Turn this into globalvar_add_simple_int(). The int * you pass
> should then be used instead of DHCP_DEFAULT_RETRY to initialize
> dhcp_param.retries in dhcp_request().


Oh...there went something totaly wrong. Sorry for that...V2 is coming

> 
> Sascha
> 

Regard
Oleg
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux