[PATCH v4 0/3] Add Davicom phy + reset-gpios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Changes in v4:
- Either register a mdio node or phy child nodes
- Check for valid phy node before registering the phy node
  This is like the kernel does it
- Also recognize compatible="ethernet-phy-id*" as PHY's
  again like the kernel, but with a simpler implementation,
  as we do not try to read the actual phy_id

Changes in v3:
- Consider the v3 a new implmentation - almost nothing was
  left from v2. Thus also invalidate any former review - sorry.
- Dropped the need for the mdio {} node, as this node is
  only used when there is dedicated HW support for the mdio.
- Added so PHY child nodes to ethernet nodes are registered,
  and as part of registration the PHY nodes are reset if
  the reset-gpios property is present.
- Further dropped that the parsed info is stored in the bus,
  as we only do reset once, thus there is no need to
  save the info from the DT
- Futher dropped helper function to reset. They was not needed
- Named the gpio with the name of the PHY node
  in the DT. This makes it unique and easier to recognize.

Changes in v2:
- Added patch to enable Davicom PHY on at91sam9263ek - evaluation kit
- Fix so we do reset before comunicating with the PHY
- Rename to mdio_reset()
- Reference correct binding file in commit log (mdio.txt)
- Tested on at91sam9263ek
  The at91sam9263ek kit do not require the reset like my
  proprietary board, so no DT changes required

Intro:
The following patches was necessary to get networking
operational on my proprietary target.
The target is at91sam9263 based with a Davicom PHY.

The Davicom PHY is a straight copy form the Linux
kernel with the interrupt routine removed and
minor adjustments to the rest.

The davicom PHY would not work until it had seen a reset
cycle - which I think may be an artifact of the board design.

To fix the reset issue I have implemented support for the
reset-gpios binding (see net/phy.txt bindings).
A minimal implmentation was done, just enough to get
my target running.

I could have implemented something in macb -
but I preferred the more generic solution.

Also included are a patch that for the at91sam9263ek
evaluation board. The patch adds several extra tools
that are usefull for testing, and enable the Davicom PHY.

        Sam

Sam Ravnborg (3):
      phylib: add Davicom PHY support
      phylib: add support for reset-gpios
      at91sam9263ek: add PHY, miitool etc. to config

 arch/arm/configs/at91sam9263ek_defconfig |  12 ++-
 drivers/net/phy/Kconfig                  |   5 ++
 drivers/net/phy/Makefile                 |   1 +
 drivers/net/phy/davicom.c                | 140 +++++++++++++++++++++++++++++++
 drivers/net/phy/mdio_bus.c               |  97 ++++++++++++++++++++-
 5 files changed, 253 insertions(+), 2 deletions(-)

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux