Re: [PATCH] ARM: lib64: Properly handle unaligned addresses in string functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 12, 2018 at 11:41 PM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
>
> On Fri, Aug 10, 2018 at 11:52:01AM -0700, Andrey Smirnov wrote:
> > Together FEC driver and parts of IP stack might end up trying to
> > memcpy() small chunks of memory from uncached (that is Device memory)
> > addresses that are not properly aligned, leading to data abort.
> >
> > To prevent such cases, add code to guard unaligned accesses and
> > redirect them to byte-wise implementations which do not have the above
> > problem.
>
> Please no. IMO this problem only shows that the FEC driver shouldn't use
> dma_alloc_coherent() to allocate its receive buffers, but instead should
> use dma_alloc + dma_sync_*.

OK, will work on that approach in v2.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux