Re: [PATCH 04/13] ARM: MXS: allow configuration of EMI clock dividers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 25, 2018 at 03:36:09PM +0200, Roland Hieber wrote:
> For now, the clock dividers are only accessible from mx28_mem_init, and
> the old prescaler of 2 is hardcoded in mx23_mem_init. I'm not sure
> if it makes sense to change it at all.
> 
> Signed-off-by: Roland Hieber <r.hieber@xxxxxxxxxxxxxx>
> ---
>  arch/arm/boards/duckbill/lowlevel.c           |  2 ++
>  arch/arm/boards/freescale-mx28-evk/lowlevel.c |  2 ++
>  arch/arm/boards/karo-tx28/lowlevel.c          |  2 ++
>  arch/arm/mach-mxs/include/mach/init.h         |  6 +++---
>  arch/arm/mach-mxs/mem-init.c                  | 16 ++++++++--------
>  5 files changed, 17 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/boards/duckbill/lowlevel.c b/arch/arm/boards/duckbill/lowlevel.c
> index 3adda68d77..393d4e1e12 100644
> --- a/arch/arm/boards/duckbill/lowlevel.c
> +++ b/arch/arm/boards/duckbill/lowlevel.c
> @@ -56,6 +56,8 @@ static noinline void duckbill_init(void)
>  	pr_debug("initializing SDRAM...\n");
>  
>  	mx28_mem_init(PINCTRL_EMI_DS_CTRL_DDR_MODE_DDR2,
> +			/* EMI_CLK of 480 / 2 * (18/21) = 205.7 MHz */
> +			2, 21,
>  			mx28_dram_vals_default);

Instead of adding more parameters to mx28_mem_init() I slighty prefer to
require the boards to call mxs_mem_init_clock() directly instead and
remove it from mx28_mem_init().

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux