Am Montag, den 18.06.2018, 22:43 -0700 schrieb Andrey Smirnov:
> Some board designs copy i.MX51 Babbadge board's PMIC design and so
> require exactly the same initialization. Move correspoding code into a
> separate file, add new compatiblity string and make appropriate
> Kconfig change to allow other boards to share that code.
>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
[...]
> +static int imx51_babbage_power_init(void)
> +{
> > + if (!of_machine_is_compatible("fsl,imx51-babbage") &&
> > + !of_machine_is_compatible("fsl,imx51-babbage-power"))
> > + return 0;
> +
> > + mc13xxx_register_init_callback(babbage_power_init);
I think it would be better for the board code to explicitly call this
setup function. Gating this by DT compatible is a bit too much magic.
Regards,
Lucas
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
