Re: [PATCH v4 53/54] ARM: i.MX8: Add i.MX8mq EVK support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 11, 2018 at 7:58 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> Hi Andrey,
>
> On Mon, Jun 11, 2018 at 10:53 PM, Andrey Smirnov
> <andrew.smirnov@xxxxxxxxx> wrote:
>
> > +       pinctrl_fec1_data_tx: fec1datatxgrp {
> > +               pinmux = <
> > +                       MX8MQ_IOMUXC_ENET_TD3_ENET1_RGMII_TD3
> > +                       MX8MQ_IOMUXC_ENET_TD2_ENET1_RGMII_TD2
> > +                       MX8MQ_IOMUXC_ENET_TD1_ENET1_RGMII_TD1
> > +                       MX8MQ_IOMUXC_ENET_TD0_ENET1_RGMII_TD0
> > +                       MX8MQ_IOMUXC_ENET_TXC_ENET1_RGMII_TXC
> > +                       MX8MQ_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL
> > +               >;
> > +               drive-strength = <7>;
> > +               slew-rate = <3>;
>
> In the arm linux kernel list it was suggested that the old pinctrl
> style (the same we use on mx5/mx6/mx7) should be used instead of this
> new generic pinctrl setting.
>

Yeah, I think I saw that ML discussion when I was researching this.
AFAICT from looking at for-next in Shawn's tree,
fsl,imx7ulp-pinctrl.txt is still going to be using "new style"
binding, so the code that I wrote is still useful to support that. And
once upstream Linux DT i.MX8M code trickles down, it should be pretty
trivial to switch to old sytle just by changing .flags. With all that
in mind, I'd be inclined to keep code as is unless told to change it
by Sascha.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux