Re: [PATCH] commands: oftree: kill oftree -f

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 11, 2018 at 06:35:48PM +0000, Alexander Kurz wrote:
> Hi Sascha,
> On Mon, 11 Jun 2018, Sascha Hauer wrote:
> 
> > Being able to free the live device tree seemed like a good idea in the
> > early days of device tree support when the first boards were brought up.
> > It turned out to be illusory that noone stores pointers to the live tree
> > which become invalid when oftree -f is executed. Enough people stumbled
> > upon crashed boards with this option, so remove it finally.
> 
> oftree -f is still in use in boot scripts, e.g. for the kindle-mx50,
> and at least one other board.
> The usecase for the kindle-mx50 is
> * DT based barebox
> * ATAGs dependent antiquated, non upgradeable kernel
> 
> start_linux() (arch/arm/lib32/armlinux.c) wont do setup_tags() if there
> still exists an oftree.
> If there is an alternative way to make boot issue 
> ATAGs, removing the -f option would be fine.
> 
> May I mention an old (rejected) proposal about this issue
> http://lists.infradead.org/pipermail/barebox/2016-December/028633.html
> 
> Also note: it's still in Documentation/user/devicetree.rst

Thanks for noting. I was a bit enthusiastic that I finally found the
energy to kill this option and forgot why I haven't done it earlier ;)
I just sent an updated series which should solve the issue of being able
to do a ATAG boot.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux