On Fri, May 18, 2018 at 04:41:29PM -0400, Vivien Didelot wrote:
> When a SoC such as VF610 has no addresses programmed for both its
> interfaces, the "No MAC address set" warning can be confusing:
>
> booting 'net'
> WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01
> WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42
>
> This patch uses dev_warn() instead and removes the redundant "warning":
>
> booting 'net'
> WARNING: eth0: No MAC address set. Using random address a2:e8:be:79:72:01
> WARNING: eth1: No MAC address set. Using random address 4e:be:c4:bc:ce:36
>
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
Applied, thanks
Sascha
> ---
> net/net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index 94954677c..d21855415 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
> char str[sizeof("xx:xx:xx:xx:xx:xx")];
> random_ether_addr(edev->ethaddr);
> ethaddr_to_string(edev->ethaddr, str);
> - pr_warn("warning: No MAC address set. Using random address %s\n", str);
> + dev_warn(&edev->dev, "No MAC address set. Using random address %s\n", str);
> eth_set_ethaddr(edev, edev->ethaddr);
> }
>
> --
> 2.17.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
