On Wed, May 9, 2018 at 1:48 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > Am Dienstag, den 08.05.2018, 14:29 -0700 schrieb Andrey Smirnov: >> Simplify the use of dma_flush_range() by changing its signature to >> accept pointer to start of the data and data size. This change allows >> us to avoid a whole bunch of repetitive arithmetic currently done by >> all of the callers. >> >> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > One nit below, otherwise > Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > >> --- >> arch/arm/cpu/mmu.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c >> index b14a869af..fc7102700 100644 >> --- a/arch/arm/cpu/mmu.c >> +++ b/arch/arm/cpu/mmu.c >> @@ -142,8 +142,11 @@ static u32 *find_pte(unsigned long adr) >> > return &table[(adr >> PAGE_SHIFT) & 0xff]; >> } >> >> -static void dma_flush_range(unsigned long start, unsigned long end) >> +static void dma_flush_range(void *ptr, size_t size) >> { >> > + unsigned long start = (unsigned long)ptr; >> + unsigned long end = start + size; > > Personal taste, but I don't like those extra spaces. They tend to not > line up as well after a few future code changes. > Sure, I can fix that in v2. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox