Hi Andrey,
On Tue, May 08, 2018 at 02:29:30PM -0700, Andrey Smirnov wrote:
> Both TTB index and address used to fill that entry are derived from
> the same variable 'addr' which requires shifting right and left by 20
> and somewhat confusing.
>
> Split the counter used to iterate over elements of TTB into a
> separate variable to make this code a bit easier to read.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
> arch/arm/cpu/mmu.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/mmu.h b/arch/arm/cpu/mmu.h
> index 59f72049f..8b51e3f9f 100644
> --- a/arch/arm/cpu/mmu.h
> +++ b/arch/arm/cpu/mmu.h
> @@ -28,8 +28,12 @@ static inline void
> create_sections(uint32_t *ttb, unsigned long addr,
> int size_m, unsigned int flags)
> {
> - for (addr >>= 20; addr < size_m; addr++)
> - ttb[addr] = (addr << 20) | flags;
> + unsigned long ttb_start = add >> 20;
This will break compilation. "addr" instead of "add".
Sascha
> + unsigned long ttb_end = ttb_start + size_m;
> + unsigned int i;
> +
> + for (i = ttb_start; i < ttb_end; i++, addr += SZ_1M)
> + ttb[i] = addr | flags;
> }
>
>
> --
> 2.17.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
