This commit fixes the mistake introduced in the commit 34fadb685905 ('commands: i2c_write: enable raw write to address'). The intended behaviour for i2c_write command is "use raw i2c write only if reg address is not defined". Before the commit 34fadb685905 reg address == 0 was acceptable. After the commit 34fadb685905 reg address == 0 became unacceptable ("undefined") and will lead to raw i2c write. Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx> --- commands/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commands/i2c.c b/commands/i2c.c index 21c39fe5af..f0d16af0cb 100644 --- a/commands/i2c.c +++ b/commands/i2c.c @@ -131,7 +131,7 @@ static int do_i2c_write(int argc, char *argv[]) for (i = 0; i < count; i++) *(buf + i) = (char) simple_strtol(argv[optind+i], NULL, 0); - if (reg > 0) { + if (reg >= 0) { ret = i2c_write_reg(&client, reg | wide, buf, count); } else { ret = i2c_master_send(&client, buf, count); -- 2.17.0 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox