On Mon, Apr 16, 2018 at 12:13 AM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > Hi Andrey, > > On Sat, Apr 14, 2018 at 10:50:17AM -0700, Andrey Smirnov wrote: >> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> >> --- >> arch/arm/mach-imx/imx6.c | 4 +++- >> arch/arm/mach-imx/include/mach/reset-reason.h | 2 ++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-imx/imx6.c b/arch/arm/mach-imx/imx6.c >> index 14a1cba5a..3d81c2785 100644 >> --- a/arch/arm/mach-imx/imx6.c >> +++ b/arch/arm/mach-imx/imx6.c >> @@ -19,6 +19,7 @@ >> #include <mach/imx6.h> >> #include <mach/generic.h> >> #include <mach/revision.h> >> +#include <mach/reset-reason.h> >> #include <mach/imx6-anadig.h> >> #include <mach/imx6-regs.h> >> #include <mach/generic.h> >> @@ -151,6 +152,7 @@ int imx6_init(void) >> { >> const char *cputypestr; >> u32 mx6_silicon_revision; >> + void __iomem *src = IOMEM(MX6_SRC_BASE_ADDR); >> >> imx6_init_lowlevel(); >> >> @@ -195,7 +197,7 @@ int imx6_init(void) >> } >> >> imx_set_silicon_revision(cputypestr, mx6_silicon_revision); >> - >> + imx_set_reset_reason(src + IMX6_SRC_SRSR); > > This will get overwritten by the watchdog driver if enabled. > I am not sure I see how. Imx_watchdog_detect_reset_source() reports reset sources with the same priority as this code, so reset_source_set_priority() should bail out early without changing anything in that case. Regardless, even if it were true, I think that behavior is perfectly OK. First of all, startup log will still be present, which is IMHO pretty useful. Second, the platforms that doen't use/rely on built-in watchdog would benefit from this. Another thing we can do is add code to respect "reset-source-priority" to imxwd.c, so that people could ajdust what reset source info they want to see via DT. Let me know what you think. Thanks, Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox