Re: [PATCH 0/2] Make finding fixup nodes more robust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,

On Fri, Jan 26, 2018 at 09:46:32PM +0100, Sam Ravnborg wrote:
> Hi Sasha.
> 
> On Fri, Jan 26, 2018 at 08:26:42PM +0100, Sascha Hauer wrote:
> > Recently the node names in i.MX6 device tree files have changed. The
> > leading zeroes were removed from the addresses. With this a newer
> > barebox doesn't find the nodes to fixup in an old device tree and
> > an older barebox doesn't find the nodes in a new device tree. To
> > fix this we create new names of the nodes based on things that hopefully
> > don't change: We iterate up to a node which is MMIO space mappable
> > and get a name that starts with "[adr]". For the remaining parts of
> > a node we add "<reg>" when the hierarchy level has a "reg" property
> > and only as last fallback we add "{nodename}" in curly brackets.
> > This name is safe against node name changes and also against adding
> > a new hierarchy level in the device tree (when for example a bus level
> > is added).
> I think I was bitten by something similar while toying with display
> timings.
> 
> So I think commands/of_display_timings.c would benefit
> from a conversion to this new scheme too - as well as the mtd stuff
> in of/partition.c

of/partition.c is fixed in this series. I haven't looked around what
else could benefit from this. Could you try it for the display timing?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux